FORMS-7696 Add support for 6.5 client library theme approach to arche… #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type page component
suryansh29
reviewed
Mar 30, 2023
| data-sly-use.formstructparser="com.adobe.cq.forms.core.components.models.form.FormStructureParser" | ||
| data-sly-test.themeClientLibRef="${symbol_dollar}{formstructparser.themeClientLibRefFromFormContainer}"> | ||
| <sly data-sly-test="${symbol_dollar}{themeClientLibRef}" data-sly-call="${symbol_dollar}{clientlib.css @ categories=themeClientLibRef}"/> | ||
| </sly> |
There was a problem hiding this comment.
Why do we need this in archetype, it is already there in core-component repo?
cc @pankaj-parashar @barshat7
There was a problem hiding this comment.
There was a problem hiding this comment.
My understanding is the archetype overrides these files for the proxy over what is present in the core components. This means that any changes done in the core components do not get reflected in projects deployed via the archetype.
The only solution, for now, is to keep the overriding done for the archetype consistent with what is provided by the core components until we reach a state where no custom overriding is needed at the archetype level.
10 tasks
pankaj-parashar
approved these changes
Apr 26, 2023
…onent (#1066) Co-authored-by: barshatr <barshatr@adobe.com>
pankaj-parashar
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…type page component
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: