Drop redundant last_dim min

adityagoel4512 · Jan 10, 2024 · ff69ae8 · ff69ae8
1 parent cf91ede
commit ff69ae8
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/onnxruntime/core/providers/cpu/nn/string_split.cc b/onnxruntime/core/providers/cpu/nn/string_split.cc
@@ -76,23 +76,21 @@ Status StringSplit::Compute(OpKernelContext* context) const {
   input_slices.reserve(input_data.size());
   int64_t last_dim = 1;
 
-  for (auto input_iter = input_data.begin(); input_iter != input_data.end(); input_iter++, num_tokens_iter++) {
+  for (auto input_iter = input_data.begin(); input_iter != input_data.end(); ++input_iter, ++num_tokens_iter) {
     auto substrs = ComputeSubstrings(*input_iter, delimiter_, maxsplit_);
     auto substr_count = static_cast<int64_t>(substrs.size());
     input_slices.push_back(std::move(substrs));
     last_dim = std::max(last_dim, substr_count);
     *num_tokens_iter = substr_count;
   }
 
-  last_dim = std::min(last_dim, maxsplit_ + 1);
-
   // Set up splits output
   auto splits_shape = input->Shape().AsShapeVector();
   splits_shape.push_back(last_dim);
 
   auto splits_data = context->Output(0, splits_shape)->template MutableDataAsSpan<std::string>();
   auto slices_iter = input_slices.begin();
-  for (auto output_splits_iter = splits_data.begin(); output_splits_iter != splits_data.end(); output_splits_iter += last_dim, slices_iter++) {
+  for (auto output_splits_iter = splits_data.begin(); output_splits_iter != splits_data.end(); output_splits_iter += last_dim, ++slices_iter) {
     std::copy(slices_iter->begin(), slices_iter->end(), output_splits_iter);
   }