Make message delivery not synchronous on the thread calling BasicConsume / BasicPublish. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ume / BasicPublish. Adjust tests to account for the change.
|
Once again, wonderful work! I only allowed myself a few cosmetic changes for code style consistency purpose (otherwise said, you do the heavy lifting, I added the useless polishing stuff :)). By the way, this may solve deadlocks I also had from time to time in unit tests (and they fatally only ever happened in our CI, not locally...)! Thanks for that! Updated nuget is coming soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to better mimic the behaviour of the actual
RabbitMQ.Clientlibrary, which runs message deliveries in one or more tasks. This is important for my use-case, as I have code that relies on this threading model, and deadlocks if message deliveries are synchronous.