Make RabbitServer's Queues and Exchanges public. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consequently make other types public that would otherwise result in compile errors due to inconsistent visibilities. The motivation for this is that without exposing the server's Queues and Exchanges, it's impossible (or at least impractical to the point where I don't understand how) to assert about state in unit tests, which renders the library unusable for its intended purpose.
|
By reading your PR title, I was at first concerned this would leak implementation details to the output world. My concen here is that integrating future versions of the RabbitMQ client might require breaking changes in those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consequently make other types public that would otherwise result in compile errors due to inconsistent visibilities.
The motivation for this is that without exposing the server's Queues and Exchanges, it's impossible (or at least impractical to the point where I don't understand how) to assert about state in unit tests, which renders the library unusable for its intended purpose.