This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Change type of TDigest.Group.id from int to long #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption is that the id is unique. If the id value overflows, it can lead to NullPointerExceptions. Changing the type to long doesn't make overflows impossible, but highly unlikely.
tdunning
reviewed
Oct 29, 2019
| @@ -541,14 +541,14 @@ public String toString() { | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
| return id; | |||
| return Long.hashCode(id); | |||
There was a problem hiding this comment.
What is the point of hashing the id?
|
Thanks, switching to MergingDigest indeed shows some nice performance improvements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption is that the id is unique. If the id value overflows, it
can lead to NullPointerExceptions. Changing the type to long doesn't
make overflows impossible, but highly unlikely.
This fixes issues like #100