Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

I think should check value before set it to bits. #129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

I think should check value before set it to bits. #129

wants to merge 5 commits into from

Commits on Mar 17, 2017

  1. RegisterSet class set and updateIfGreater method update value, but ha… 

    …ve not check weather the value greater than 0x1f.

may be that is a bug.
    @wangchuan2008888
    wangchuan2008888 committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    466bafb View commit details
    Browse the repository at this point in the history

  2. assign value bigger than 0x1F to RegisterSet would cause a assert, if… 

    … have not check the value.

and I think maybe change the 0x1F depends on RegisterSet.REGISTER would be better.
    @wangchuan2008888
    wangchuan2008888 committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    b0c18c8 View commit details
    Browse the repository at this point in the history

  3. This is the version of set/updateIfGreater after check value

    @wangchuan2008888
    wangchuan2008888 committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    41d131c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2017

  1. Update RegisterSet.java

    @wangchuan2008888
    wangchuan2008888 committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    443cb4f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2017

  1. add getCardinality to bloom filter

    andrew committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    fb0b130 View commit details
    Browse the repository at this point in the history