Play advertisements #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediaminister
force-pushed
the
ads
branch
3 times, most recently
from
94a80ce
to
d3d05f9
Compare
|
Do you know why they need to know the weather? Are other ads provided then? |
|
Yes, this is used for "Weather based marketing". And Facebook does this, so everyone else copies it. |
|
Never knew this was a thing! |
mediaminister
force-pushed
the
ads
branch
4 times, most recently
from
fb07177
to
a7bddf0
Compare
|
I rebased this to v0.2.0. |
|
@mediaminister what's the status of this PR? Can this be merged, or does this have issues? I remember reading somewhere that the playlist approach causes some problems, but I'm not sure anymore where I read that or what issues it could cause. |
|
Not mergeable, this PR breaks Kodi resume points... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements playing advertisements before programs.