Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: AAT v1 readyness (fixes: #24) #25

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Update: AAT v1 readyness (fixes: #24) #25

merged 7 commits into from
Feb 24, 2023

Conversation

joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Feb 20, 2023 •
edited
Loading

Update

Testing

  1. Upload to AAT to ensure compatibility

Blockers

Currently unable to test in v1 AAT.

@joe-replin joe-replin self-assigned this Feb 20, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 21, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the readme be updated to be inline with the vimeo plugin where it details each setting please. Might be out of scope of the PR but worth mentioning

schema/component.schema.json Show resolved Hide resolved
schema/component.schema.json Outdated Show resolved Hide resolved
schema/course.schema.json Outdated Show resolved Hide resolved
@joe-replin
Copy link
Contributor Author

joe-replin commented Feb 23, 2023 •
edited
Loading

Could the readme be updated to be inline with the vimeo plugin where it details each setting please. Might be out of scope of the PR but worth mentioning

Absolutely. I've gone through and made sure each YouTube setting is covered in the README.

@joe-replin
Copy link
Contributor Author

All of your recommendations have been included, @guywillis. Thanks for the thorough review. I'm still currently unable to test this PR in the v1 AAT instance.

guywillis
guywillis approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-replin joe-replin merged commit a019f26 into master Feb 24, 2023
@joe-replin joe-replin deleted the issue/24 branch February 24, 2023 18:20
github-actions bot pushed a commit that referenced this pull request Feb 24, 2023
@semantic-release-bot
Chore(release): 3.2.0 [skip ci]
c263295 
# [3.2.0](v3.1.0...v3.2.0) (2023-02-24)

### Update

* AAT v1 readyness (fixes: #24) (#25) ([a019f26](a019f26)), closes [#24](#24) [#25](#25)
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-replin joe-replin

Labels
bug enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

targetAttribute missing from schema
3 participants
@joe-replin @guywillis @cahirodoherty-learningpool