Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add font size variable for nav button label (fixes #414) #415

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix: Add font size variable for nav button label (fixes #414) #415

merged 1 commit into from
Apr 27, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Apr 5, 2023 •
edited
Loading

Fixes #414

Fix

  • Adds new variable @nav-btn-label-size for the nav button label font size.

Steps for testing

  1. Switch core to issue/338
  2. In course.json, enable nav labels with:
  "_navigation": {
    "_showLabel": true
  },
  1. Adjust @nav-btn-label-size in your theme and see it reflected in the nav button label text.

Requires

@swashbuck swashbuck self-assigned this Apr 5, 2023
@swashbuck swashbuck marked this pull request as ready for review April 5, 2023 17:12
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck mentioned this pull request Apr 18, 2023
Merged
joe-allen-89
joe-allen-89 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster
Copy link
Member

Awaiting adaptlearning/adapt-contrib-core#339

@swashbuck swashbuck merged commit 0a9c548 into master Apr 27, 2023
@swashbuck swashbuck deleted the issue/414 branch April 27, 2023 16:19
@github-actions
Copy link

🎉 This PR is included in version 9.6.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@kirsty-hames kirsty-hames Awaiting requested review from kirsty-hames

@joe-replin joe-replin Awaiting requested review from joe-replin

@guywillis guywillis Awaiting requested review from guywillis

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation Button API support
5 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @ethan-lp @joe-allen-89