Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Replace @navigation-height with --adapt-navigation-height (fixes #187) #188

Merged
merged 3 commits into from
May 2, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Apr 24, 2023

Fixes #187

Breaking

  • Replaces @navigation-height with --adapt-navigation-height CSS variable

Testing

  1. In course.json, set _navigation._navigationAlignment to 'bottom'
  2. Enable Trickle on some blocks
  3. Ensure Navigation and/or Trickle aren't overlapping each other

Dependencies

Core - Navigation Button API
adaptlearning/adapt-contrib-core#339

@swashbuck swashbuck self-assigned this Apr 24, 2023
@swashbuck swashbuck changed the title Fix: Replace @navigation-height with --adapt-navigation-height (fixes #187) Breaking: Replace @navigation-height with --adapt-navigation-height (fixes #187) Apr 24, 2023
Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 0079d6e into master May 2, 2023
@swashbuck swashbuck deleted the issue/187 branch May 2, 2023 16:21
@github-actions
Copy link

github-actions bot commented May 2, 2023

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Button API support - nav height variable
5 participants