Fix: Added cmi.objectives _recordObjectives and id existence check (fixes #316) #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
changed the title
oliverfoster
changed the title
danielghost
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
cmi.objectives.n.id shouldn't really need to be checked if it already exists, as it is acceptable to set this to the same value each time. The cost of the additional calls required to loop through the records will be negligable, so worth including if this overcomes LMS implementation issues.
Likewise there are some LMSs that haven't implemented objectives correctly where supported, so good idea to be able to explicitly switch this off for such cases.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
## [5.9.8](v5.9.7...v5.9.8) (2024-04-29) ### Chore * Readme updates for broken links, clarity, and linting errors (fixes #312) (#313) ([df90b8d](df90b8d)), closes [#312](#312) [#313](#313) ### Fix * Added cmi.objectives _recordObjectives and id existence check (fixes #316) (#317) ([71e88df](71e88df)), closes [#316](#316) [#317](#317) ### Upgrade * Bump ip from 1.1.8 to 1.1.9 (#311) ([1728659](1728659)), closes [#311](#311)
|
🎉 This PR is included in version 5.9.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #316
Fix
_recordObjectivesconfig