issue/3281 Added data-order to allow sorting of nav buttons #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-steele
reviewed
Feb 3, 2022
| @@ -13,6 +13,12 @@ export default class PageLevelProgressNavigationView extends Backbone.View { | |||
| return 'btn-icon nav__btn nav__pagelevelprogress-btn pagelevelprogress__nav-btn'; | |||
| } | |||
|
|
|||
| attributes() { | |||
| return { | |||
| 'data-order': (Adapt.course.get('_globals')?._extensions?._pageLevelProgress?._navOrder || 90) | |||
There was a problem hiding this comment.
Code is defaulting to 90, so should the schemas also use 90 for the default?
There was a problem hiding this comment.
Ach no, I'll set to 0. because float:right inverts the current visual order, reordering these correctly in the dom will currently produce the wrong visual order. These should default to 0 but at least be available to change in a project or when we move to floats in the vanilla theme.
chris-steele
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of adaptlearning/adapt_framework#3281
using adaptlearning/adapt-contrib-core#61
Added
data-orderattribute to navigation bar button to allow sorting