Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Close loading screen via router.hideLoading() (fixes #86) #87

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix: Close loading screen via router.hideLoading() (fixes #86) #87

merged 1 commit into from
Sep 11, 2023

Conversation

swashbuck
Copy link
Contributor

Fix #86

Fix

  • Close loading screen via router.hideLoading()

@swashbuck swashbuck self-assigned this Aug 30, 2023
@oliverfoster
Copy link
Member

Could you bump the fw version in the package.json to correspond where appropriate.

@swashbuck
Copy link
Contributor Author

Could you bump the fw version in the package.json to correspond where appropriate.

@oliverfoster The required FW should only be 5.10.0. The new Core changes in PR #435 are not breaking. So, I think we’re fine?

@oliverfoster
Copy link
Member

Ref: adaptlearning/adapt-contrib-spoor#292 (comment)

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit e9a4767 into master Sep 11, 2023
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/86 branch September 11, 2023 09:11
@github-actions
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close loading screen via router.hideLoading()
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89