Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add option to make entire menu items clickable (fixes #157) #188

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

New: Add option to make entire menu items clickable (fixes #157) #188

wants to merge 17 commits into from

Commits on Apr 9, 2024

  1. Add _areEntireItemsClickable option, update documentation

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e794c5b View commit details
    Browse the repository at this point in the history

  2. Update schemas

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    732e195 View commit details
    Browse the repository at this point in the history

  3. Optimizations to className() and events()

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    426b8c1 View commit details
    Browse the repository at this point in the history

  4. Refactor className() using an array

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    372f4e1 View commit details
    Browse the repository at this point in the history

  5. Update attributes() to simplify getting parent attributes

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0dee1c9 View commit details
    Browse the repository at this point in the history

  6. Move click event to boxmenu-item__inner instead of boxmenu-item

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a4fa56d View commit details
    Browse the repository at this point in the history

  7. Make areEntireItemsClickable a getter function

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2c85651 View commit details
    Browse the repository at this point in the history

  8. Refactor attributes()

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8410ee8 View commit details
    Browse the repository at this point in the history

  9. Update itemCount in attributes()

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7ccc459 View commit details
    Browse the repository at this point in the history

  10. Move aria labels to .boxmenu-item__inner

    @swashbuck
    swashbuck committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    be16139 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Move aria-label to new element 

    Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
    @swashbuck @oliverfoster
    swashbuck and oliverfoster authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ad3f8c4 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @swashbuck
    swashbuck committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    01bcaee View commit details
    Browse the repository at this point in the history

  3. Fix missing closing if

    @swashbuck
    swashbuck committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    230d46a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Update README.md

    @oliverfoster
    oliverfoster authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f806326 View commit details
    Browse the repository at this point in the history

  2. Make boxmenu-item__inner focusable by adding tabindex attribute

    @swashbuck
    swashbuck committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    df96e26 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Add keydown event for keyboard navigation

    @swashbuck
    swashbuck committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0310042 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Move preventDefault 

    Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
    @swashbuck @oliverfoster
    swashbuck and oliverfoster authored May 14, 2024
    Configuration menu
    Copy the full SHA
    14979b3 View commit details
    Browse the repository at this point in the history