Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add link role to menu item View buttons (fixes #159) #161

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

swashbuck
Copy link
Contributor

Fixes #159

Fix

  • Adds role="link" to the menu item "View" buttons

@swashbuck swashbuck changed the title Add role='link' to View button Fix: Add link role to menu item View buttons (fixes #159) Jul 19, 2023
@swashbuck swashbuck self-assigned this Jul 19, 2023
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks @swashbuck. Tested on Mac safari running voiceOver.

Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit e7a77b5 into master Jul 20, 2023
1 check passed
@swashbuck swashbuck deleted the issue/159 branch July 20, 2023 14:29
@github-actions
Copy link

🎉 This PR is included in version 6.3.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View button should use the "link" role
5 participants