Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button aria text partially broken when using groups #160

Closed
swashbuck opened this issue Jul 19, 2023 · 1 comment · Fixed by #162
Closed

Button aria text partially broken when using groups #160

swashbuck opened this issue Jul 19, 2023 · 1 comment · Fixed by #162
Assignees
@kirsty-hames
Labels
accessibility bug released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jul 19, 2023 •
edited
Loading

Subject of the issue

When using menu grouping, the "View" button aria text that states "Item 1 of 4" is partially broken (ex. "Item 1 of ." where the item count is missing).

Relates to #156

Your environment

  • Framework 5.31.12
  • Box Menu 6.3.10
@swashbuck swashbuck added the bug label Jul 19, 2023
@swashbuck swashbuck assigned swashbuck and unassigned swashbuck Jul 19, 2023
@kirsty-hames kirsty-hames self-assigned this Aug 16, 2023
@kirsty-hames kirsty-hames mentioned this issue Aug 16, 2023
Merged
joe-allen-89 pushed a commit that referenced this issue Sep 13, 2023
@kirsty-hames @swashbuck @oliverfoster
Fix: Update item count ARIA for grouped items (fixes #160) (#162)
f3ea395 
* Update item count for grouped items

* remove _nthChild from updated item count

* set models.length to a variable

Co-authored-by: Brad Simpson <brad.simpson@kineo.com>

* Update js/BoxMenuGroupView.js

---------

Co-authored-by: Brad Simpson <brad.simpson@kineo.com>
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
github-actions bot pushed a commit that referenced this issue Sep 13, 2023
@semantic-release-bot
Chore(release): 6.3.12 [skip ci]
f964de6 
## [6.3.12](v6.3.11...v6.3.12) (2023-09-13)

### Fix

* Update item count ARIA for grouped items (fixes #160) (#162) ([f3ea395](f3ea395)), closes [#160](#160) [#162](#162)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.3.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Update item count ARIA for grouped items (fixes #160) adaptlearning/adapt-contrib-boxMenu
2 participants
@swashbuck @kirsty-hames