Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM dependencies that point to URLs #53

Closed
ricksbrown opened this issue Aug 18, 2016 · 2 comments
Closed

NPM dependencies that point to URLs #53

ricksbrown opened this issue Aug 18, 2016 · 2 comments

Comments

@ricksbrown
Copy link

This in your dependencies: "download": "git://github.com/adaptlearning/download.git" makes life very difficult in a secure enterprise environment behind a strict corporate firewall.

While we can point npm to a private (in-house) repository this does not affect dependencies that point to a URL instead of a package in npm. These sorts of requests are simply blocked and even if we could have them let them through the firewall we would have a dependency on a cloud resource that we do not control and therefore not have truly repeatable builds.

This is a terrible design decision on the behalf of npm itself, not actually your own issue, but it would be nice if you could find a way to avoid this sort of "non npm repository" dependency.

I raise this issue merely so you are aware of this impediment to users in strict corporate environments.

ricksbrown added a commit to ricksbrown/adapt-cli that referenced this issue Nov 3, 2016
@oliverfoster
Copy link
Member

oliverfoster commented Nov 10, 2016

fixed with adapt-cli@2.0.4 please confirm

@moloko
Copy link
Contributor

moloko commented Dec 12, 2018

closing due to lack of f/b

@moloko moloko closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants