Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Support running app directories directly via flower-simulation #3810

Merged
merged 24 commits into from
Jul 16, 2024
Merged

feat(framework) Support running app directories directly via flower-simulation #3810

merged 24 commits into from
Jul 16, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jul 15, 2024 •
edited
Loading

Assumes #3813 is merged

flower-simulation --app <fab-like-dir> --run-config <overrides> --num-supernodes=N

@jafermarq jafermarq changed the title feature(framework) Support running FAB directly via `flower-simulation. feature(framework) Support running FAB directly via flower-simulation Jul 15, 2024
jafermarq and others added 17 commits July 15, 2024 23:06
@jafermarq
Merge branch 'main' into support-fab-in-flower-simulation
29ae904
@jafermarq
fix args checks
6b7e88d
@jafermarq
basic functionality; no override; no from .fab
4d4b049
@charlesbvll
feat(framework:skip) Add config function for fusing dicts
6d99d90
@jafermarq
simplify
8430e28
@jafermarq
Merge branch 'add-config-function-overrides' into support-fab-in-flow…
97c0614 
…er-simulation
@jafermarq
using fused config -- but not in ClientApp yet
11086ba
@jafermarq
Merge branch 'main' into support-fab-in-flower-simulation
e709b08
@jafermarq
updates
46244de
@jafermarq
init
da0d8f1
@jafermarq
fix
e2d2347
@jafermarq @danieljanes
Apply suggestions from code review
122cb31 
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@jafermarq
updates
307c29e
@jafermarq
Merge branch 'main' into register-context-using-fab-dir
952572c
@jafermarq
updates
3ec626d
@jafermarq
Merge branch 'register-context-using-fab-dir' into support-fab-in-flo…
f65dcbf 
…wer-simulation
@jafermarq
clientapp gets runconfig from pyproject.toml
909d410
@jafermarq jafermarq changed the title feature(framework) Support running FAB directly via flower-simulation feature(framework) Support running app directories directly via flower-simulation Jul 16, 2024
@jafermarq jafermarq changed the title feature(framework) Support running app directories directly via flower-simulation feat(framework) Support running app directories directly via flower-simulation Jul 16, 2024
@jafermarq jafermarq marked this pull request as ready for review July 16, 2024 14:17
@jafermarq jafermarq mentioned this pull request Jul 16, 2024
Merged
danieljanes
danieljanes reviewed Jul 16, 2024
View reviewed changes
src/py/flwr/simulation/run_simulation.py Outdated Show resolved Hide resolved
src/py/flwr/simulation/run_simulation.py Outdated Show resolved Hide resolved
src/py/flwr/simulation/run_simulation.py Show resolved Hide resolved
src/py/flwr/simulation/run_simulation.py Outdated Show resolved Hide resolved
src/py/flwr/simulation/run_simulation.py Outdated Show resolved Hide resolved
jafermarq and others added 2 commits July 16, 2024 17:18
@jafermarq @danieljanes
Apply suggestions from code review
8f89927 
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@jafermarq
update
a7a68f6
@danieljanes danieljanes merged commit 87de8ae into main Jul 16, 2024
28 checks passed
@danieljanes danieljanes deleted the support-fab-in-flower-simulation branch July 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafermarq @danieljanes @charlesbvll