refactor(framework) Improve app loading in simulation engine #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
changed the title
danieljanes
reviewed
Jul 15, 2024
danieljanes
approved these changes
Jul 15, 2024
danieljanes
changed the title
chongshenng
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of the Simulation Engine has a simple mechanism to load the function that would eventually return a
ClientApp. As Flower has rapidly evolved in terms of what's the origin of aClientAppobject (e.g. a simple python file, or a full FAB) so it has the ways of loading these apps (e.g. loading an associatedpyproject.toml)This PR reuses the same mechanism that
flower-supernodeuses to load a function that returns aClientApp. This step represent the first step towards being able to run full FABs fromflower-simulation.In addition, this PR caches the
ClientAppbefore starting the simulation, making them more efficient to run.