Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Capture node_id/node_config in Context via NodeState #3780

Merged
merged 16 commits into from
Jul 12, 2024
Merged

feat(framework) Capture node_id/node_config in Context via NodeState #3780

merged 16 commits into from
Jul 12, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jul 11, 2024 •
edited
Loading

Changes in this PR:

  • Register node_id and node_config to the NodeState
  • The NodeState will register a Context passing its node_id and node_config
  • For grpc_rere the create_node() function returns the node_id returned by the CreateNodeResponse. This is used to set the <NodeState>.node_id.
  • Updated places in the code base that directly initialise a Context

@jafermarq jafermarq mentioned this pull request Jul 12, 2024
Merged
@jafermarq jafermarq marked this pull request as ready for review July 12, 2024 08:24
@jafermarq jafermarq marked this pull request as draft July 12, 2024 11:14
@jafermarq jafermarq marked this pull request as ready for review July 12, 2024 13:42
@danieljanes @jafermarq
refactor(framework) Refactor NodeState handling (#3787)
a53c9b9 
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
@danieljanes danieljanes changed the title feat(framework) Capture node_id and node_config in Context via the NodeState feat(framework) Capture node_id/node_config in Context via NodeState Jul 12, 2024
@danieljanes danieljanes enabled auto-merge (squash) July 12, 2024 15:29
@danieljanes danieljanes merged commit 01ca846 into main Jul 12, 2024
29 checks passed
@danieljanes danieljanes deleted the add-node-id-and-node-config-to-context branch July 12, 2024 15:29
chongshenng pushed a commit that referenced this pull request Jul 16, 2024
@jafermarq @danieljanes @chongshenng
feat(framework) Capture node_id/node_config in Context via `Nod…
07a3ebf 
…eState` (#3780)

Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes