Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Add utility functions for config parsing and handling #3732

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 7, 2024

Issue

Description

We need some functions to parse a config arguments to a flattened config dict.

Related issues/PRs

The current PR is need to unblock #3720

Proposal

Explanation

  • Introduce a flatten_dict function to flatten nested dictionaries and a parse_config_args function that parses a comma separated list of key values pairs separated by '=' to a single flat dictionary.

  • Add corresponding tests

Checklist

  • Implement proposed change
  • Write tests
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 7, 2024 13:37
danieljanes
danieljanes previously approved these changes Jul 8, 2024
@danieljanes danieljanes enabled auto-merge (squash) July 8, 2024 14:47
@danieljanes danieljanes merged commit 26d2dd9 into main Jul 8, 2024
29 checks passed
@danieljanes danieljanes deleted the add-config-utils-functions branch July 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants