Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(framework:skip) Add no-op indent level to _start_client_internal #3564

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

The diff for #3090 is messy because of an indentation change.

Related issues/PRs

#3090

Proposal

Explanation

Add the indent change without modifying the functionality of the code in order to make the diffs for #3090 easier to review.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review June 9, 2024 15:05
@danieljanes danieljanes changed the title refactor(framework:skip) Add indent level to client-app refactor(framework:skip) Add indent level to _start_client_internal Jun 9, 2024
@danieljanes danieljanes changed the title refactor(framework:skip) Add indent level to _start_client_internal refactor(framework:skip) Add no-op indent level to _start_client_internal Jun 9, 2024
@danieljanes danieljanes merged commit 111eecc into main Jun 9, 2024
31 checks passed
@danieljanes danieljanes deleted the refactor-client-app branch June 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants