Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(framework:skip) Add details about the ownership of mounted volumes #3530

Merged
merged 6 commits into from
May 31, 2024

Conversation

Robert-Steiner
Copy link
Member

Issue

Description

  • Adds details about the ownership of mounted volumes.
  • Removes another forgotten client:app argument.
  • Moves the virtual environment from /app/venv to /python to ensure that the venv is not overridden when a local directory is mounted into /app directory of the container.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Co-authored-by: Danny <danny.heinrich@flower.ai>
@Robert-Steiner Robert-Steiner marked this pull request as ready for review May 30, 2024 11:47
Moep90
Moep90 previously approved these changes May 30, 2024
Signed-off-by: Robert Steiner <robert@flower.ai>
@tanertopal tanertopal enabled auto-merge (squash) May 31, 2024 14:49
@tanertopal tanertopal disabled auto-merge May 31, 2024 14:49
@tanertopal tanertopal enabled auto-merge (squash) May 31, 2024 14:49
@tanertopal tanertopal merged commit e944ac0 into main May 31, 2024
29 checks passed
@tanertopal tanertopal deleted the fix/move-virtual-env branch May 31, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants