Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*:skip) Enforce the skip flag on wildcard PRs #3478

Merged
merged 5 commits into from
May 22, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Currently the wildcard can be used for describing PRs modifying multiple projects, but the changelog doesn't support such PRs.

Related issues/PRs

N/A

Proposal

Explanation

Those PRs should be marked as :skip, we therefore enforce the :skip flag to be used when * is used in the title.

Checklist

  • Implement proposed change
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review May 20, 2024 16:54
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question rest looks good to me!

dev/check_pr_title.py Show resolved Hide resolved
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 90a3cd4 into main May 22, 2024
29 checks passed
@tanertopal tanertopal deleted the enforce-skip-on-wildcard branch May 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants