Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add alpine base image #3453

Merged
merged 11 commits into from
May 17, 2024
Merged

feat(framework) Add alpine base image #3453

merged 11 commits into from
May 17, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented May 15, 2024 •
edited
Loading

Issue

Description

  • Adds Alpine Docker base image.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@Robert-Steiner
feat(framework:ci) add alpine base image
64dac6d 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner self-assigned this May 15, 2024
Moep90
Moep90 reviewed May 16, 2024
View reviewed changes
src/docker/base/alpine/Dockerfile Outdated Show resolved Hide resolved
doc/source/contributor-how-to-build-docker-images.rst Show resolved Hide resolved
src/docker/base/alpine/Dockerfile Outdated Show resolved Hide resolved
@Robert-Steiner
fix typo
ca8f43b 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner
Add alpine to workflow
201bb5a 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner
update copyright
dc41f34 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner marked this pull request as ready for review May 16, 2024 14:15
Robert-Steiner and others added 4 commits May 16, 2024 16:38
@Robert-Steiner
rename os to distro
0a4d23c 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner
remove explicit package versions
fcd23c1 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner
add distro name
5e5cdac 
Signed-off-by: Robert Steiner <robert@flower.ai>
@tanertopal
Merge branch 'main' into feature/alpine-base-image
9c1d70d
Moep90
Moep90 previously approved these changes May 17, 2024
View reviewed changes
@Robert-Steiner Robert-Steiner changed the title feat(framework:ci) Add alpine base image feat(framework) Add alpine base image May 17, 2024
Robert-Steiner and others added 2 commits May 17, 2024 09:47
@Robert-Steiner
Merge branch 'main' into feature/alpine-base-image
69e089b
@Robert-Steiner
fix env
7b32567 
Signed-off-by: Robert Steiner <robert@flower.ai>
tanertopal
tanertopal approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tanertopal tanertopal enabled auto-merge (squash) May 17, 2024 16:20
@tanertopal tanertopal merged commit 0f0631a into main May 17, 2024
29 checks passed
@tanertopal tanertopal deleted the feature/alpine-base-image branch May 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongshenng chongshenng chongshenng left review comments

@tanertopal tanertopal tanertopal approved these changes

@Moep90 Moep90 Moep90 left review comments

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees

@Robert-Steiner Robert-Steiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Robert-Steiner @tanertopal @Moep90 @chongshenng