Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the private class vars of RecordSet with a different approach. #3368

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Hide the private class vars of RecordSet with a different approach. #3368

merged 2 commits into from
Apr 30, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Apr 30, 2024

To be consistent with Metadata, Message, etc.

@danieljanes danieljanes enabled auto-merge (squash) April 30, 2024 14:21
@danieljanes danieljanes merged commit 01cf4fb into main Apr 30, 2024
28 checks passed
@danieljanes danieljanes deleted the rs-hide-udpate branch April 30, 2024 16:31
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@panh99 @mohammadnaseri
Hide the private class vars of RecordSet with a different approach (#…
ae74c90 
…3368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @danieljanes