Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move run_client_app to supernode.app #3352

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Move run_client_app to supernode.app #3352

merged 3 commits into from
Apr 29, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Apr 29, 2024 •
edited
Loading

  • Move the run_client_app to supernode/app.py.
  • Restructure the run_client_app.

@panh99 panh99 marked this pull request as ready for review April 29, 2024 08:52
jafermarq
jafermarq approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danieljanes danieljanes merged commit 20098cb into main Apr 29, 2024
28 checks passed
@danieljanes danieljanes deleted the mv-run-client-app branch April 29, 2024 16:50
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@panh99 @mohammadnaseri
Move run_client_app to supernode.app (#3352)
e4482e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq