Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuse Driver and DriverGrpc #3273

Merged
merged 16 commits into from
Apr 20, 2024
Merged

Fuse Driver and DriverGrpc #3273

merged 16 commits into from
Apr 20, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Apr 16, 2024 •
edited
Loading

This PR:

  • fuses the driver.py and grpc_driver.py.
  • renames GrpcDriver as GrpcDriverHelper. (as a 1st step to later rename Driver as GrpcDriver, which takes place in Use abstract Driver #3281 )

Base automatically changed from driver-abc to main April 18, 2024 20:51
@jafermarq jafermarq marked this pull request as ready for review April 19, 2024 07:09
@danieljanes danieljanes enabled auto-merge (squash) April 20, 2024 11:24
@danieljanes danieljanes merged commit 79c785a into main Apr 20, 2024
27 checks passed
@danieljanes danieljanes deleted the fuse-driver-driverhelper branch April 20, 2024 11:25
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@jafermarq @mohammadnaseri
Fuse Driver and DriverGrpc (#3273)
c756e08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes