Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add State.get_run #3261

Merged
merged 15 commits into from
Apr 18, 2024
Merged

Add State.get_run #3261

merged 15 commits into from
Apr 18, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Apr 15, 2024 •
edited
Loading

  • Added State.get_run.
  • Extended State.creat_run.
  • Implemented SqliteState.get_run and InMemoryState.get_run.
  • Passed fab_id="None/None", fab_version="None" to State.create_run in DriverServicer.
  • Updated unit tests accordingly.

@panh99 panh99 changed the title Getrun state Add State.get_run Apr 15, 2024
@panh99 panh99 marked this pull request as ready for review April 15, 2024 16:15
danieljanes
danieljanes previously approved these changes Apr 18, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) April 18, 2024 18:55
@danieljanes danieljanes merged commit fd55940 into main Apr 18, 2024
27 checks passed
@danieljanes danieljanes deleted the getrun-state branch April 18, 2024 19:42
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@panh99 @mohammadnaseri
Add State.get_run (#3261)
3bfc7f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @danieljanes