Remove deprecated mxnet examples and docs #3207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongshenng
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
|
@tanertopal @jafermarq @danieljanes Any thoughts on this PR? |
tanertopal
reviewed
Apr 8, 2024
| @@ -162,7 +162,6 @@ def find_test_modules(package_path): | |||
| # Renamed pages | |||
| "installation": "how-to-install-flower.html", | |||
| "configuring-clients.html": "how-to-configure-clients.html", | |||
| "quickstart_mxnet": "tutorial-quickstart-mxnet.html", | |||
There was a problem hiding this comment.
@charlesbvll In case we would instead of removing redirect these to the docs landing page it would be the following I believe:
"quickstart_mxnet": "index.html",
Can you comment on that? I might be wrong.
There was a problem hiding this comment.
@tanertopal Yes, that would work, we should also add the redirect for the current url:
"quickstart_mxnet": "index.html",
"quickstart-mxnet": "index.html",
|
Closing this PR to decouple it into smaller PRs for updating redirects and removing code examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since
mxnethas been retired in September 2023, this PR deprecates and removes the Flower examples and docs formxnet.Checklist
[ ] Write tests#contributions)Changelog entry