Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add created_at to Metadata #3174

Merged
merged 22 commits into from
Mar 27, 2024
Merged

Add created_at to Metadata #3174

merged 22 commits into from
Mar 27, 2024

Conversation

jafermarq
Copy link
Contributor

  • Adds created_at to Message.Metadata and it's value is set upon Message creation.
  • The SuperLink no longer sets created_at.
  • Validation of created_at has been updated.

@jafermarq jafermarq mentioned this pull request Mar 27, 2024
Merged
Base automatically changed from ttl-revision-2 to main March 27, 2024 18:20
@jafermarq jafermarq marked this pull request as ready for review March 27, 2024 19:07
danieljanes
danieljanes reviewed Mar 27, 2024
View reviewed changes
src/py/flwr/common/message_test.py Outdated
metadata=metadata,
content=None if content_fn is None else content_fn(maker),
error=None if error_fn is None else error_fn(0),
)

assert message.metadata.created_at > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could record the timestamp before the message gets created and assert that created_at is greater.

danieljanes
danieljanes previously approved these changes Mar 27, 2024
View reviewed changes
@danieljanes danieljanes merged commit c8da9f3 into main Mar 27, 2024
28 checks passed
@danieljanes danieljanes deleted the ttl-revision-3 branch March 27, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes