Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secaggplus workflow log #3108

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Mar 11, 2024

The ServerApp log when using SecAggPlusWorkflow:
image

The ServerApp log in app-secure-aggregation when using SecAggPlusWorkflowWithLogs:
image

This PR also fixed the following small errors in SA-related code:

  • Replaced named_values with ConfigsRecord and configs. The named_values is an old name that should be removed.
  • Wrote the history when the secure aggregation was completed. Previously, the SecAggPlus workflow does not write the history like the default_fit_workflow.
  • Renamed masked input/masked inputs to masked vectors, which is easier to understand.

@danieljanes danieljanes merged commit 100b0ab into main Mar 11, 2024
28 checks passed
@danieljanes danieljanes deleted the update-secaggplus-workflow-log branch March 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants