Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Central DP (client-side adaptive clipping) #2892

Merged
merged 148 commits into from
Feb 28, 2024
Merged

Central DP (client-side adaptive clipping) #2892

merged 148 commits into from
Feb 28, 2024

Conversation

mohammadnaseri
Copy link
Contributor

@mohammadnaseri mohammadnaseri commented Feb 1, 2024 •
edited
Loading

Issue

Description

Central DP, also known as user-level DP, enables differential privacy strategies in Flower with client-side adaptive clipping.

Related issues/PRs

Proposal

Explanation

A new class, DifferentialPrivacyClientSideAdaptiveClipping, has been added. It can be wrapped around a strategy class to enable central DP with adaptive clipping. The clipping phase of clients' model updates is performed at the clients' sides. Each client can use the middleware adaptiveclipping_mod modifier for the clipping phase.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

mohammadnaseri and others added 30 commits January 15, 2024 16:17
@mohammadnaseri
Add central DP server side fixed clipping
6ba0507
@mohammadnaseri
Add central DP server-side fixed clipping unit tests
e66e1ad
@mohammadnaseri
Fix exceptin msg
a88f72e
@mohammadnaseri
Add the new strategy wrapper
b2c08ad
@mohammadnaseri
Fix merge conflicts
902fed8
@mohammadnaseri
WIP
57a2d65
@mohammadnaseri
WIP
b9aab13
@mohammadnaseri
WIP
64ef649
@mohammadnaseri
WIP
53d393e
@mohammadnaseri
WIP
888fa47
@mohammadnaseri
WIP
e7788d6
@mohammadnaseri
Merge branch 'main' into central-dp-server-side-fixed-clipping
91e5ef7
@mohammadnaseri
Clean code
16c1c41
@mohammadnaseri
WIP
497cbc9
@mohammadnaseri
Clean code
4b84265
@mohammadnaseri
Fix tests
93d8d75
@mohammadnaseri
Fix
464c3e9
@mohammadnaseri
Fix test error
bade827
@mohammadnaseri
Clean code
800eac6
@mohammadnaseri
Clean code
a257d7f
@mohammadnaseri
Fix pylint error
d1d3ff5
@mohammadnaseri
Fix pylint error
d24de45
@mohammadnaseri
Add minor comment
ba7a00c
@mohammadnaseri
WIP
b196bd7
@mohammadnaseri
Merge branch 'main' into central-dp-server-side-fixed-clipping
58d0e49
@mohammadnaseri
Merge branch 'central-dp-server-side-fixed-clipping' into central-dp-…
32a1f41 
…client-side-fixed-clipping
@mohammadnaseri
Minor fix
6cb406c
@mohammadnaseri
Fix noise:
27f4b63
@mohammadnaseri
Refactor
bacde18
@mohammadnaseri
Fix test
e70d9fe
panh99
panh99 reviewed Feb 28, 2024
View reviewed changes
src/py/flwr/common/differential_privacy.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/__init__.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/dp_adaptive_clipping.py Outdated Show resolved Hide resolved
src/py/flwr/client/mod/__init__.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/dp_fixed_clipping.py Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) February 28, 2024 16:05
@danieljanes danieljanes merged commit bf35ca1 into main Feb 28, 2024
28 checks passed
@danieljanes danieljanes deleted the central-dp-client-side-adaptive-clipping branch February 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panh99 panh99 panh99 left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadnaseri @danieljanes @panh99