Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to the current server dockerimage #2680

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Small improvements to the current server dockerimage #2680

merged 1 commit into from
Dec 4, 2023

Conversation

Robert-Steiner
Copy link
Member

Issue

Official Flower Docker images

Description

  • Added some environment variables that are common for running python in docker.
  • Added --no-cache-dir because of DL3042
  • Made the Ubuntu version configurable.
  • Removed installation of poetry. We install the server via pip therefore there is no pyproject.toml poetry can read from. @tanertopal can you please check if this is correct.

@Robert-Steiner Robert-Steiner changed the title small improvements to the current server dockerimage Small improvements to the current server dockerimage Dec 4, 2023
@tanertopal tanertopal enabled auto-merge (squash) December 4, 2023 13:00
tanertopal
tanertopal approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal merged commit 9d182ce into main Dec 4, 2023
27 checks passed
@tanertopal tanertopal deleted the docker-server-image branch December 4, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robert-Steiner @tanertopal