Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wav2vec baseline #2551

Merged
merged 45 commits into from
Nov 4, 2023
Merged

Add Wav2vec baseline #2551

merged 45 commits into from
Nov 4, 2023

Conversation

jafermarq
Copy link
Contributor

Adds wav2vec 2.0 baseline originally implemented by @tuanct1997 but now following the new format in the baselines.

This makes #1780 #1771 obsolete

jafermarq and others added 30 commits September 23, 2023 09:20
@jafermarq
init empty
a826ffc
@jafermarq
wip
383760a
@jafermarq
wip
af861b0
@jafermarq
more
a6bed51
@jafermarq
trains
7170fc7
@jafermarq
run
0c85963
@jafermarq
changes: it crashes when loading server data (id=199999)
7269210
@jafermarq
small fix, still server fails
9613f30
@jafermarq
init
00170ad
@jafermarq
minor tweaks; added README
7e5dc67
@jafermarq
w/ previous
03c5d0a
@jafermarq
Merge pull request #4 from jafermarq/flower-slurm-example
059c58f 
Adding SLURM example
@jafermarq
Update README.md
6eb1c21
@jafermarq
Update README.md
2b8ce39
@tuanct1997
fix path and data
49ed7a7
@tuanct1997
update data csv processing, update pretrained huggingface download on…
18907e9 
…ce and remove unecessary elements
@tuanct1997
Merge branch 'wav2vec-baseline' into fedw2v2_fix
2408778
@tuanct1997
fixed resource and path issue, change hyperparams to fit with the paper
4ee7e8e
@tuanct1997
Add evaluation fraction at client side and edit server path
2b39c37
@tuanct1997
removed folder as requested
fbe3aa3
@jafermarq
Merge pull request #10 from tuanct1997/fedw2v2_fix
a77db6b 
Update wav2vec2 baseline
@jafermarq
updates
2551cce
@tuanct1997
Update README.md
7132361 
Add data and hyperparams description
@tuanct1997
Add Readme experiments section and result
4f76821
@tuanct1997
Merge branch 'wav2vec-baseline' into fedw2v2_fix
85703a2
@jafermarq
Merge pull request #11 from tuanct1997/fedw2v2_fix
8c6cf1b 
Add Readme section
@tuanct1997
Update README.md
d426007 
Grammar correct
@jafermarq
Merge pull request #12 from tuanct1997/patch-1
1db5455 
Update README.md
@jafermarq
minor udpates to readme; new figure
cffdf4d
@jafermarq
tests pass; small fix
d0c0486
@jafermarq jafermarq added the summer-of-reproducibility About a baseline for Summer of Reproducibility label Oct 31, 2023
@jafermarq jafermarq changed the title Wav2vec baseline Add Wav2vec baseline Oct 31, 2023
jafermarq
jafermarq commented Oct 31, 2023
View reviewed changes
Copy link
Contributor Author

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tuanct1997,

Just some minor comments

baselines/fedwav2vec2/pyproject.toml Outdated Show resolved Hide resolved
baselines/fedwav2vec2/pyproject.toml Outdated Show resolved Hide resolved
baselines/fedwav2vec2/fedwav2vec2/conf/sb_config/w2v2.yaml Outdated Show resolved Hide resolved
baselines/fedwav2vec2/README.md Outdated Show resolved Hide resolved
jafermarq and others added 13 commits October 31, 2023 17:24
@jafermarq jafermarq marked this pull request as ready for review November 3, 2023 17:54
@jafermarq jafermarq enabled auto-merge (squash) November 3, 2023 17:55
@jafermarq jafermarq enabled auto-merge (squash) November 3, 2023 18:34
@jafermarq jafermarq merged commit 0b6b617 into adap:main Nov 4, 2023
26 checks passed
This was referenced Nov 4, 2023
Closed
Closed
@TParcollet
Copy link
Contributor

@tuanct1997 jumping randomly and way after the battle in this PR, is it expected that the sorting is set to descending? This is fairly uncomon for ASR training in SB as this feature is mostly used for debugging purpose?

@tuanct1997
Copy link
Contributor

@tuanct1997 jumping randomly and way after the battle in this PR, is it expected that the sorting is set to descending? This is fairly uncomon for ASR training in SB as this feature is mostly used for debugging purpose?

@TParcollet nice catch! You're absolutely right. Setting the sorting to descending isn't typical for ASR training in SB. I probably used that configuration during debugging and forgot to switch it back. I believe it should default to ascending in SB, which could potentially improve the performances.

Btw, yeah, that PR was quite the battlefield, wasn't it? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuanct1997 tuanct1997 tuanct1997 left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
summer-of-reproducibility About a baseline for Summer of Reproducibility
Projects
Summer of Reproducibility
Status: Merged !
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jafermarq @TParcollet @tuanct1997 @danieljanes