Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spacing before imports consistent #1798

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Make spacing before imports consistent #1798

merged 1 commit into from
Apr 18, 2023

Conversation

charlesbvll
Copy link
Member

What does this implement/fix? Explain your changes.

Makes the spacing at the beginning of Python files consistent, by always adding 2 line breaks between the module doc and the import section (this PR only applies to flwr, flwr_tools, and examples but not to baselines, flwr_experimental, and flwr_examples).

danieljanes
danieljanes approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I wish black was doing this automatically

@danieljanes danieljanes enabled auto-merge (squash) April 18, 2023 11:19
@danieljanes danieljanes merged commit 91196bb into main Apr 18, 2023
@danieljanes danieljanes deleted the add-consistent-spacing branch April 18, 2023 11:29
@charlesbvll charlesbvll mentioned this pull request Apr 18, 2023
Merged
tanertopal added a commit that referenced this pull request Apr 18, 2023
@tanertopal
Merge branch 'add-https-rest' of github.com:adap/flower into add-http…
5c52695 
…s-rest

* 'add-https-rest' of github.com:adap/flower:
  Exclude private members from API ref (#1797)
  Make spacing before imports consistent (#1798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @danieljanes