Fix the return type of client_fn in simulation #1766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the simulation requires client_fn of type
Callable[[str], Client]
; however, it works on both Client and NumpyClient (also, the example on the website show function with the return type of NumpyClient).This PR changes the type to
ClientLike
, which isUnion[Client, NumPyClient]
.The problem was mentioned in #1176
Both type work because the simulation uses
RayClientProxy
that calls this functionflower/src/py/flwr/client/app.py
Lines 249 to 253 in 57a4365