Federated XGBoost horizontal quickstart #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbvll
requested changes
Feb 28, 2023
There was a problem hiding this comment.
I have only added one small comment about the location of a file but other than that there still is the question of the xgboost dependency. There is no perfect way to do it, but you probably want to add it to the global pyproject.toml under the extra dependencies, in a similar fashion to ray.
src/py/flwr/common/fedxgb.py
Outdated
| @@ -0,0 +1,153 @@ | |||
| # Copyright 2020 Adap GmbH. All Rights Reserved. | |||
There was a problem hiding this comment.
This file should sit in src/py/flwr/server/strategy rather than common. common is for functions used both by server and client.
danieljanes
approved these changes
Mar 14, 2023
charlesbvll
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?