Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry proposal #1544

Merged
merged 25 commits into from
Jan 13, 2023
Merged

Add telemetry proposal #1544

merged 25 commits into from
Jan 13, 2023

Conversation

tanertopal
Copy link
Member

Reference Issues/PRs

Issue: #1534
PR: #1533

What does this implement/fix? Explain your changes.

Contains the first code draft for the linked issues.

danieljanes
danieljanes requested changes Jan 7, 2023
View reviewed changes
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
dev/test.sh Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
@tanertopal
Imrpove readability
7f16dba
@tanertopal
Make telemetry unblocking
44e0255
@tanertopal
Remove useless comments
0a1f1e9
@tanertopal
Add comments to clarify intentions in code
edd1b4c
@tanertopal
Change event names
c97a35d
@tanertopal
Merge branch 'main' into telemetry_code
43b685c 
* main:
  Fixes colab links (#1560)
  Updates Ray to 2.2.0 and fixes Mypy errors (#1555)
  Upgrade to Poetry 1.3.2 (#1549)
  Add FedAvg MNIST Baseline to README (#1552)
  Fix badge on README (#1553)
  Flower Baseline: FedAvg MNIST (#1497)
  Fix mt-pytorch example (#1545)
  Upgrade Poetry to 1.2.2 (#1547)
@tanertopal
Update telemetry code
774b6a6
@tanertopal
Update telemetry code
ee21fcf
@tanertopal tanertopal marked this pull request as ready for review January 12, 2023 04:58
danieljanes
danieljanes requested changes Jan 12, 2023
View reviewed changes
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry_test.py Outdated Show resolved Hide resolved
src/py/flwr/common/version.py Outdated Show resolved Hide resolved
@tanertopal tanertopal changed the title Add first telemetry proposal Add telemetry proposal Jan 12, 2023
tanertopal and others added 9 commits January 12, 2023 18:45
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
14c155c 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
d79679c 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
5be5354 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
849dab0 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
e26ac7f 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
@tanertopal
Fixes various tests.
9ac734c
@tanertopal
Fixes test in Python 3.7
38ab034
@tanertopal
Fixes tests in Python 3.7
8d6099f
@tanertopal
Set correct user-agent for telemetry
1838db1
danieljanes
danieljanes requested changes Jan 12, 2023
View reviewed changes
src/py/flwr/common/version.py Outdated Show resolved Hide resolved
src/py/flwr/common/version.py Outdated Show resolved Hide resolved
src/py/flwr/common/version.py Outdated Show resolved Hide resolved
src/py/flwr/common/version.py Outdated Show resolved Hide resolved
@tanertopal @danieljanes
Update src/py/flwr/common/telemetry.py
c7be466 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
danieljanes
danieljanes requested changes Jan 12, 2023
View reviewed changes
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
src/py/flwr/common/telemetry.py Outdated Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) January 13, 2023 00:19
@danieljanes danieljanes merged commit b34b772 into main Jan 13, 2023
@danieljanes danieljanes deleted the telemetry_code branch January 13, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanertopal @danieljanes