Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean quickstart-pandas example #1535

Merged
merged 8 commits into from
Jan 5, 2023
Merged

Clean quickstart-pandas example #1535

merged 8 commits into from
Jan 5, 2023

Conversation

charlesbvll
Copy link
Member

Reference Issues/PRs

Cleans #1469

What does this implement/fix? Explain your changes.

The PR mentioned above missed a pyproject.toml and a README.md, it was also reformatted and fixed so it ran smoothly. I also added some mentions of the new quickstart example in the main Flower README and a doc page for it.

Any other comments?

doc/source/quickstart-pandas.rst Outdated Show resolved Hide resolved
examples/quickstart_pandas/client.py Outdated Show resolved Hide resolved
examples/quickstart_pandas/client.py Outdated Show resolved Hide resolved
examples/quickstart_pandas/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@danieljanes danieljanes enabled auto-merge (squash) January 5, 2023 21:33
@danieljanes danieljanes merged commit b0895db into main Jan 5, 2023
@danieljanes danieljanes deleted the clean-pandas branch January 5, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants