Create saving-and-loading-Pytorch-checkpoints.rst #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Thanks for the PR @Linardos ! Looks good overall, I've added a few small suggestions. Could you re-compile the docs and check if everything looks good?
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
|
Changes committed! I look forward to your thoughts after running the code. I hope we can resolve the issue. |
|
@Linardos, lightning fast! Did you have a chance to build the docs and check if the formatting looks good? |
|
Yeap, I used a VS code plugin that allowed me to built them as I worked and your changes were small so it was easy to check pretty quickly. |
danieljanes
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
A minimal example for storing a PyTorch checkpoint. Several extra steps are added compared to the original saving progress example. Furthermore a way to load the latest checkpoint is added as well.
Any other comments?
This was developed with Daniel's help. We thought it was a resolved issue but apparently when loading the checkpoint, performance drops. It's as if training from scratch. We need to debug this further.