Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: add seeed_xiao_esp32c6 #9326

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Add: add seeed_xiao_esp32c6 #9326

merged 7 commits into from
Jun 17, 2024

Conversation

MatthewJeffson
Copy link

Add a new board Seeed Studio XIAO ESP32C6 from Seeed Studio.
Purchase: https://www.seeedstudio.com/Seeed-Studio-XIAO-ESP32C6-p-5884.html
Pinout: https://wiki.seeedstudio.com/xiao_esp32c6_getting_started/#hardware-overview
Schematic: https://files.seeedstudio.com/wiki/SeeedStudio-XIAO-ESP32C6/XIAO-ESP32-C6_v1.0_SCH_PDF_24028.pdf

Already done testing LED, digital input, Wi-Fi, analog reading, and IIC, but the UART seems a little trouble. More info and .bin file here

Creation ID has been added. Referring #6645 and thanks @prplz

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request to remove custom string.

ports/espressif/boards/seeed_xiao_esp32c6/mpconfigboard.h Outdated Show resolved Hide resolved
@MatthewJeffson
Copy link
Author

Okay, should be ok now?
Best Regards,
Matthew

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the old comment and run pre-commit: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit

Thanks for removing the message!

ports/espressif/boards/seeed_xiao_esp32c6/mpconfigboard.h Outdated Show resolved Hide resolved
@MatthewJeffson
Copy link
Author

Ah~ I got it. The pre-commit is OK now.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Looks good. Thanks!

@tannewt tannewt merged commit 6779020 into adafruit:main Jun 17, 2024
15 checks passed
@MatthewJeffson
Copy link
Author

Thanks for the merge! Hope can see the board alive on the Downloads Section on you guys websites.:)
Best Regards,
Matthew

@RetiredWizard
Copy link

Hope can see the board alive on the Downloads Section on you guys websites.:) Best Regards, Matthew

If you want to speed up the process, Adafruit is always grateful for help updating the download site 😁

https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants