Some cardputer definition improvements #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesjnadeau @CDarius @RetiredWizard @joshua-beck-0908 Take a look. |
Just looked through the commit. |
|
Looks good to me, thanks for cleaning this up! |
|
I'm phone access only (travelling 😀) so I didn't search the core to understand the MAX3421E parameter impact but the changes look good to me. |
|
Looks good to me too! |
dhalbert
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tiny improvements.
The grove port pins are labeled as G1 & G2 on the physical product.
The current definition has literally every other name for the pins, other than these.
Note: They have never been labeled as any of the other names in docs or on the physical product.
Since this board was added in 9.0.x and not 9.1 I think we should leave the rest of the other pin names as is.
The port itself is labeled PORT.A, not the pins.
While I was at it I fixed the M5Stack branding to match their website and the board default hostname.
Also for compilation time savings, I disabled the MAX3421E module, since this board doesn't have enough exposed pins to do spi (it's literally only got G1 and G2 exposed).