Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESP-IDF to 5.2.1 #9071

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Update ESP-IDF to 5.2.1 #9071

merged 7 commits into from
Mar 26, 2024

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 21, 2024

This updates the underlying I2C API and allocates memory. So, I switched busio.I2C to using a finalizer for reset instead of bulk reset.

@tannewt tannewt requested a review from dhalbert March 21, 2024 18:18
@tannewt tannewt force-pushed the idf5.2.1 branch 2 times, most recently from 6ea19b2 to bd5d693 Compare March 21, 2024 18:37
@tannewt
Copy link
Member Author

tannewt commented Mar 21, 2024

I tried this on my memento. It runs but the camera stops working. I'll look tomorrow if @jepler doesn't get to it first.

@dhalbert dhalbert added this to the 9.1.0 milestone Mar 22, 2024
@tannewt
Copy link
Member Author

tannewt commented Mar 22, 2024

Still draft because it needs: adafruit/esp32-camera#8

@bill88t
Copy link

bill88t commented Mar 23, 2024

Just out of curiosity, why is 120m unstable?
With ESP-PSRAM64(H) chips, I didn't have a single crash due to psram.
It's a supported frequency according to the datasheet. Is there an idf timing issue?

@tannewt
Copy link
Member Author

tannewt commented Mar 25, 2024

Just out of curiosity, why is 120m unstable? With ESP-PSRAM64(H) chips, I didn't have a single crash due to psram. It's a supported frequency according to the datasheet. Is there an idf timing issue?

From here:

           - Octal PSRAM 120 MHz is an experimental feature, it works when
             the temperature is stable.

               Risks:
                   If your chip powers on at a certain temperature, then after the temperature
                   increases or decreases by approximately 20 Celsius degrees (depending on the
                   chip), the accesses to / from PSRAM will crash randomly.

@tannewt tannewt marked this pull request as ready for review March 25, 2024 20:55
@tannewt
Copy link
Member Author

tannewt commented Mar 25, 2024

Ok, @dhalbert this is ready for review.

Copy link

@bill88t bill88t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port waveshare_esp32s2_pico still has CIRCUITPY_ESP_PSRAM_FREQ = 120m.
I ran a string search just in case there are others, but no.

@tannewt
Copy link
Member Author

tannewt commented Mar 26, 2024

Port waveshare_esp32s2_pico still has CIRCUITPY_ESP_PSRAM_FREQ = 120m. I ran a string search just in case there are others, but no.

I left that in because it is marked as quad not octal.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good! Looking forward to 9.1.0-beta.0!

@dhalbert dhalbert merged commit a6c6d09 into adafruit:main Mar 26, 2024
184 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants