M5Stack Cardputer : I2S_DATA pin name typo #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RetiredWizard I will wait a bit in case you have a few more changes. |
Thanks Dan! 😁 I've tested I2S Audio Out, I2C, SPI (SD Card/TFT), keyboard pins... All looks good to me. |
|
Sorry Dan, I should have reminded you when I saw you getting close to RC1, but it's probably not a big deal, this can be fixed in RC2 😁 |
dhalbert
approved these changes
Mar 14, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9057.
I'm sorry I didn't get a chance to test this before the merge but I was out of town most of this week and when I got back this evening my cardputer had just arrived 😁.
I threw the latest build on and did a few quick tests which mostly seemed to work fine. I did spot this one typo though. I'll give it some more testing tomorrow.