Add support for VIDI X board #8798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lovrojakic Are you still interested in working on this? If not, we can close the PR for now, and reopen it as needed. Note that the format of the header of the board files has changed fairly recently. |
Added additional pin names to pins.c for vidi_x board
|
Hi @dhalbert, everything seems to be working properly and I would appreciate if you could merge this PR. Thank you! |
dhalbert
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Hi - the headers of the files for boards have changed recently. Could you look at typical board files at the tip of main and redo the headers in these files to match those? Thanks.
The license and copyright lines have been replaced with SPDX-style lines. The files that previously had no header lines now do have header lines.
dhalbert
approved these changes
Jul 22, 2024
|
Thank you very much for your help! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for VIDI X board (https://vidi-x.org/).