Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three small changes #8187

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Three small changes #8187

merged 5 commits into from
Jul 24, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jul 20, 2023

  • Unify "No foo pin" errors to simplify translation maintenance and improve consistency. Also one other "busy" -> "in use" change.
  • Allocate 32 byte chunks on imx. This aligns to the cache lines and will save headaches when doing cache invalidations on the data.
  • Move three find_qstr wrappers into tcm because find_qstr is already there and they should be small. (Otherwise code in tcm may to have to jump out to flash and back for a small wrapper.)

@tannewt tannewt requested a review from dhalbert July 20, 2023 18:48
dhalbert
dhalbert approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring of errors, thanks!

dhalbert
dhalbert requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, there is no mp_raise_RuntimeError_varg() right now

@dhalbert
Copy link
Collaborator

mini_sam_m4 ja build is too big by 24 bytes.

@tannewt tannewt requested a review from dhalbert July 24, 2023 16:39
@dhalbert dhalbert merged commit 66a76d0 into adafruit:main Jul 24, 2023
14 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert