Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an exception if os.getenv is used on a board without settings.toml support #8169

Merged
merged 1 commit into from
Jul 13, 2023
Merged

throw an exception if os.getenv is used on a board without settings.toml support #8169

merged 1 commit into from
Jul 13, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Jul 13, 2023 •
edited by dhalbert
Loading

No description provided.

tannewt
tannewt approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 8de9d5a into adafruit:main Jul 13, 2023
431 checks passed
@jepler jepler deleted the os-getenv-exception branch July 13, 2023 17:50
@dhalbert dhalbert mentioned this pull request Jul 23, 2023
Merged
@dhalbert dhalbert changed the title throw an exception if os.getenv is used on a board without settings.t… throw an exception if os.getenv is used on a board without settings.toml support Jul 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @tannewt