Add optional parameter for using internal pull-up for int1 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perja12
force-pushed
the
perja/internal_pull_up
branch
2 times, most recently
from
111bc2c
to
2f41bbf
Compare
|
please replace with a try/except so that if htere is no internal pullup support, it just gets skipped |
This is useful in cases where there is no support for internal pull-up resistor on the board (for example Binho Nova host adapter). On such devices, one have to use an external pull-up resistor.
perja12
force-pushed
the
perja/internal_pull_up
branch
from
2f41bbf
to
d72b75d
Compare
|
Thanks @ladyada. I have updated the code. Please take a look again. |
|
great work! |
ladyada
approved these changes
Aug 13, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 29, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.2.0 from 5.1.23: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#79 from perja12/perja/internal_pull_up Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#12 from adam-huganir/docs-fix-tutorial-link-update Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.1.11 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#92 from FoamyGuy/docs_fix > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#91 from rhooper/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in cases where there is no support for internal pull-up resistor on the board (for example Binho Nova host adapter). On such devices, one have to use an external pull-up resistor.