remove ImageFont.getsize() usage for Pillow 10.0.0 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will resolve the actions error from adafruit/Adafruit_CircuitPython_MatrixPortal#91 as well as other attempts to use Blinka_DisplayIO with Pillow version 10.0.0 which was released recently.
I found the new API to use from the Pillow release notes: https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html#font-size-and-offset-methods
The new function returns a tuple with size 4 instead of 2, so I've used slice to make a drop-in replacement for the now removed
getsize()I confirmed this by adding some print statements to the fontio.py file temporarily.I did only very minimal testing with the PyGame Display simpletest script.